Upload multiple files in session

Forgot to mention that I received an array of the following error:

 {
    '.tag': 'lookup_failed',
    lookup_failed: { '.tag': 'incorrect_offset', correct_offset: 257523 }
  }

Hi MatthiD

You can definitely just start an upload session and then finish it, without needing to use `filesUploadSessionAppendV2`. 

Looking at the code snippet provided, it looks like you are starting an upload session by calling `filesUploadSessionStart()`, but are attempting to finish that same session by calling `filesUploadSessionFinishBatchV2()`. While this technically does work — `filesUploadSessionFinishBatchV2()` will finish an upload session started with `filesUploadSessionStart()` — you may want to use one of the following combinations:

• `filesUploadSessionStart()` and `filesUploadSessionFinish()`
• `filesUploadSessionStartBatch()` and `filesUploadSessionFinishBatchV2()`

Keep in mind that `filesUploadSessionStart()` is meant to upload a single file, whereas `filesUploadSessionStartBatch()` starts a batch of upload sessions.

Additionally, since there is no functionality to separate the files, please ensure you are not combining all of the file data of multiple files into one large buffer — use one upload session per file needing to be uploaded.

To answer your additional questions:

• An upload session is a temporary process that allows large files to be uploaded in smaller chunks instead of a single request.
• An entry is information pertaining to a file in the batch of files.
• Could you clarify what you are wanting to achieve by "accessing one session from multiple entries"?

Lastly, the error you are receiving means:

The specified offset was incorrect. See the value for the correct offset. This error may occur when a previous request was received and processed successfully but the client did not receive the response, e.g. due to a network error.

The "correct_offset" value from the response you provided means that the Dropbox API had only received 257523 bytes for the upload session so far. The error "incorrect_offset" was thrown because the Dropbox API received a value other than 257523 in your request.

Feel free to take a look at this example for an idea of how an upload session can be handled.

For best practices when uploading files via the Dropbox API, please refer to our Performance Guide.

Hey DB-Des ,

thank you so much for the detailed answer.
I already saw the examples and explanations, but could not adapt it to my specific use case.
Meanwhile I solved the issue.

Two things I recognized/learned:

• I did not understand the cursor concept at first. I thought, it should point to the beginning of the file part, but after sending data the cursor should point to the end of the file part (file length) in the finish method.
  Maybe a graphic or animation would be helpful to explain this.
• I am still unsure about the `filesUploadSessionStartBatch()` and `filesUploadSessionFinishBatchV2()`. According to the documentation, these two do not send any data in combination, right? So we would need either the `filesUploadSessionAppendV2` or the “missing” `filesUploadSessionAppendBatchV2`. Since the whole thing was to reduce requests due to a 429 of the looped uploadFile method, I don’t understand why I should go with the single append method and call it multiple times again. Performance guide says:
  
  

  For each file in a batch, in parallel, call /files/upload_session/append_v2 as needed to upload the full contents of the file over multiple requests.

  
  Why? Does it mean that the buffer prevents the 429s (regardless to the amount of requests to the buffer)? Maybe a graphic would help here as well to understand the steps and the infrastructure.

I solved everything for my case, but wanted to drop these thoughts for people having the same problem.

Additionally my code that worked for me:

async function filesUploadSessionAppendBatch(
  content: ArrayBufferLike,
  entries: AppendBatchEntry[],
) {
    // this gets a token or a new one if it is expired
  const accessToken = await dropboxMaker.getToken();
  const response = await fetch(
    "https://content.dropboxapi.com/2/files/upload_session/append_batch",
    {
      method: "POST",
      headers: {
        Authorization: `Bearer ${accessToken}`,

        "Dropbox-API-Arg": JSON.stringify({
          entries,
        }).replace(/[\u007f-\uffff]/g, getSafeUnicode),

        "Content-Type": "application/octet-stream",
      },
      body: content,
    },
  );
  return response.json();
}
export async function uploadFiles(files: UploadFileData[]) {
    const num_sessions = files.length;
    try {
      if (num_sessions < 1) {
        return {};
      }
      const dbx = await dropboxMaker.client();
      if (num_sessions === 1) {
        // upload one file
        await dbx.filesUpload({
          ...files[0],
        });
      } else {
        // upload multiple files 
        // merges all files in one ArrayBuffer (to make one single request....will still be far away from the upload limit)
        const allContent = concatArrayBuffers(
          ...files.map(({ contents }) => contents),
        );
  
        const startResponse = await dbx.filesUploadSessionStartBatch({
          num_sessions,
        });
        const { session_ids } = startResponse.result;
  
        const batchData: Array<FullBatchEntry> = files.reduce(
          (
            acc: { offset: number; entries: Array<FullBatchEntry> },
            cur,
            index,
          ) => {
            acc.entries.push({
              close: true,
              cursor: {
                session_id: session_ids[index],
                offset: 0,
                // always start with 0 for a new session. Don’t upcount.
              },
              commit: {
                autorename: true,
                /** @ts-expect-error Wrong type used (see CommitInfo) */
                mode: "add",
                mute: false,
                path: cur.path,
              },
              length: cur.contents.byteLength,
            });
            // not needed anymore
            // acc.offset += cur.contents.byteLength;
            return acc;
          },
          {
            offset: 0,
            entries: [],
          },
        ).entries;
    
        await filesUploadSessionAppendBatch(
          allContent,
          batchData.map(({ cursor, length, close }) => ({
            cursor,
            length,
            close,
          })),
        );
  
        await dbx.filesUploadSessionFinishBatchV2({
          entries: batchData.map(({ commit, cursor, length }) => ({
            commit,
            cursor: {
              ...cursor,
              // point to the end of the upload file part...so length
              offset: length,
            },
          })),
        });
      }
    } catch (error) {
      console.log(error);
    }
  }

Thanks again for your help 💙

MatthiD, I'm glad to hear you were able to find a solution for your use case.

To clarify, there are different types of 429 errors. It is always recommended to log the error message that accompanies an error code to get a better idea of what may be happening with the request.

To help avoid a potential lock contention error (429 too_many_write_operations), which might have been the case here, an upload session operation is recommended because of the way it handles uploads — as described in the Performance Guide:

Each file upload to Dropbox consists of the following stages: appending the byte contents of the file to an upload buffer on the Dropbox server, obtaining a namespace lock, and then committing those bytes as a file into a target namespace. The /files/upload endpoint does this atomically, whereas upload session decouples these steps.