We’re Still Here to Help (Even Over the Holidays!) - find out more here.
Forum Discussion
Uploading big file using Objective-C API V2 very SLOW...
Hello, recently our app updates the Dropbox related code from API V1 to API V2. Usually we need to transfer files to Dropbox, it is OK for small files, but for video files of size about 1.5 GB th...
Hi Greg,
thanks for reply!
1. I have tried to pass the chunk of data with size 5 MB and 100 MB, but the result was the same. It seems that the bytesWritten from the progress block is always 32768 and in few cases also 65536, as shown in the log message. How can I modify the data chunk size for each transfer? Currently I use the following code:
NSData *data = [dropboxObj.fileHandle readDataOfLength:length]; // length = 5 MB or 100 MB or other values
uploadTask = [client.filesRoutes uploadSessionStartData:data];
2. Just a few minutes ago I tried to upload again, but there is no message from the progress block, and after one or two minutes the operation is canceled. My network is normal. So I guess there might be something wrong with the connection to Dropbox, or is there still anything in API V2 that I should know
when doing the upload ?
Thanks for your attention!
Logan
thanks for reply!
1. I have tried to pass the chunk of data with size 5 MB and 100 MB, but the result was the same. It seems that the bytesWritten from the progress block is always 32768 and in few cases also 65536, as shown in the log message. How can I modify the data chunk size for each transfer? Currently I use the following code:
NSData *data = [dropboxObj.fileHandle readDataOfLength:length]; // length = 5 MB or 100 MB or other values
uploadTask = [client.filesRoutes uploadSessionStartData:data];
2. Just a few minutes ago I tried to upload again, but there is no message from the progress block, and after one or two minutes the operation is canceled. My network is normal. So I guess there might be something wrong with the connection to Dropbox, or is there still anything in API V2 that I should know
when doing the upload ?
Thanks for your attention!
Logan
Greg-DB
Dropbox Community Moderator
Dropbox Community Moderator1. The chunk size should just be the size of the data you supply for any given call, and that's what should get reported back in the progress callback, so it's unexpected that you'd still get 32768. Can you share the rest of the relevant code, including the definition of length, the progresc callback definitifion, etc.?
2. That also doesn't sound like the expected behavior. If you share the rest of the code and the steps to reproduce it we'll be happy to look into it.
// My code can be summarized as follows:
// sorry for the indentation, it seems the code indentation is gone.
const NSUInteger DB_CHUNK_SIZE = 5*1024*1024;
DropboxClient *client = [DropboxClientsManager authorizedClient];
// create dropboxObj to pass parameters
TGDropboxObject *dropboxObj = [[TGDropboxObject alloc] init];
dropboxObj.progressBlock = progress;
dropboxObj.completionBlock = completion;
dropboxObj.fileSize = [self getFileSize:localPath fromInternal:fromInternal];
dropboxObj.chunkSize = DB_CHUNK_SIZE;
dropboxObj.curTotalBytes = 0;
dropboxObj.srcPath = localPath;
dropboxObj.dstPath = remotePath;
dropboxObj.fromInternal = fromInternal;
if (fromInternal) {
dropboxObj.fileHandle = [NSFileHandle fileHandleForReadingAtPath:localPath];
}
// skip……NSData *data = [self readDataOfLength:dropboxObj.chunkSize fromObj:dropboxObj];// read one chunk of data
DBUploadTask<DBFILESUploadSessionStartResult *, DBNilObject *> *uploadTask;
uploadTask = [client.filesRoutes uploadSessionStartData:data];
[uploadTask response:^(DBFILESUploadSessionStartResult * _Nullable result, DBNilObject * _Nullable obj, DBRequestError * _Nullable requestError) {
if (result) { // success for the first chunk
dropboxObj.sessionId = result.sessionId;
DBFILESUploadSessionCursor *cursor = [[DBFILESUploadSessionCursor alloc] initWithSessionId:result.sessionId offset:[NSNumber numberWithUnsignedLongLong:[self getOffsetFromObj:dropboxObj]]];
[self uploadNextFromObj:dropboxObj cursor:cursor];// do upload for subsequent chunks
}
else { // failure
[self closeFileFromObj:dropboxObj];// skip…
dropboxObj.completionBlock(nil, error);
}
}];// progress block for uploadTask
[uploadTask progress:^(int64_t bytesWritten, int64_t totalBytesWritten, int64_t totalBytesExpectedToWrite) {
dropboxObj.curTotalBytes += bytesWritten;
CGFloat progress = (CGFloat)dropboxObj.curTotalBytes / (CGFloat)dropboxObj.fileSize;
NSLog(@"start: bytesWritten = %lld progress = %.4f", bytesWritten, progress);
dropboxObj.progressBlock(progress);
}];// The method for uploading subsequent chunks:
//-------------------------------------------------------
- (void)uploadNextFromObj:(TGDropboxObject *)dropboxObj cursor:(DBFILESUploadSessionCursor *)cursor {
DropboxClient *client = [DropboxClientsManager authorizedClient];
NSData *const chunk = [self readDataOfLength:dropboxObj.chunkSize fromObj:dropboxObj];
const BOOL isLastChunk = chunk.length < dropboxObj.chunkSize;
if (isLastChunk == NO) {
DBUploadTask<DBNilObject *, DBFILESUploadSessionLookupError *> *continueTask;
continueTask = [client.filesRoutes uploadSessionAppendV2Data:cursor inputData:chunk];
[continueTask response:^(DBNilObject * _Nullable obj, DBFILESUploadSessionLookupError * _Nullable lookupError, DBRequestError * _Nullable requestError) {
if (lookupError == nil) { // success
DBFILESUploadSessionCursor *cursor = [[DBFILESUploadSessionCursor alloc] initWithSessionId:dropboxObj.sessionId offset:[NSNumber numberWithUnsignedLongLong:[self getOffsetFromObj:dropboxObj]]];
[self uploadNextFromObj:dropboxObj cursor:cursor];} else { // failure
[self closeFileFromObj:dropboxObj];
// skip…dropboxObj.completionBlock(nil, error);
}
}];// progress block for continueTask
[continueTask progress:^(int64_t bytesWritten, int64_t totalBytesWritten, int64_t totalBytesExpectedToWrite) {
dropboxObj.curTotalBytes += bytesWritten;
CGFloat progress = (CGFloat)dropboxObj.curTotalBytes / (CGFloat)dropboxObj.fileSize;
NSLog(@"continue: bytesWritten = %lld progress = %.4f", bytesWritten, progress);
dropboxObj.progressBlock(progress);
}];
}
else { // last chunk
DBUploadTask<DBFILESFileMetadata *, DBFILESUploadSessionFinishError *> *finishTask;
DBFILESCommitInfo *info = [[DBFILESCommitInfo alloc] initWithPath:dropboxObj.dstPath];
finishTask = [client.filesRoutes uploadSessionFinishData:cursor commit:info inputData:chunk];
[finishTask response:^(DBFILESFileMetadata * _Nullable metaData, DBFILESUploadSessionFinishError * _Nullable finishError, DBRequestError * _Nullable requestError) {
DLog(@"metaData: %@", metaData);
[self closeFileFromObj:dropboxObj];
// skip…dropboxObj.completionBlock(metaData, error);
}];
[finishTask progress:^(int64_t bytesWritten, int64_t totalBytesWritten, int64_t totalBytesExpectedToWrite) {
dropboxObj.curTotalBytes += bytesWritten;
CGFloat progress = (CGFloat)dropboxObj.curTotalBytes / (CGFloat)dropboxObj.fileSize;
NSLog(@"finish: bytesWritten = %lld progress = %.4f", bytesWritten, progress);
dropboxObj.progressBlock(progress);
}];
}
}// If there is anything unclear, just tell me, I can provide further infomation.
- Greg-DBThanks! Your definition DB_CHUNK_SIZE of seems like it should be fine, but I don't see exactly where it's actually being used. Can you share the definitions of TGDropboxObject, readDataOfLength, getOffsetFromObj, closeFileFromObj, and anything else necessary so I can try to run this? Thanks in advance!
You cannot run the code without our external device. But the following code does the same thing and produces the the same result.
You need to provide the source file to be uploaded. The destination file is hard coded (/temp/test.mp4), you can modify it to another file path. The unused parameters in the API uploadInternal:files:index:fromDir:toDropboxDir:opType:resArray: can be ignored.
If there is anything unclear, feel free to point out.
const NSUInteger DB_BLOCK_SIZE = 5*1024*1024; // 102400000;
@interface DestVC ()
@property DBUploadTask<DBFILESUploadSessionStartResult *, DBNilObject *> * uploadTask;
@property DBUploadTask<DBNilObject *, DBFILESUploadSessionLookupError *> * continueTask;
@property DBUploadTask<DBFILESFileMetadata *, DBFILESUploadSessionFinishError *> *finishTask;
@property unsigned long long offset;
@property NSFileHandle *file;
@property NSData *data;
@property NSNumber *fileSize;
@property DropboxClient *client;
@property NSString *sessionId;
@end
@implementation DestVC
- (void)uploadInternal:(NSArray *)items files:(NSArray *)files index:(int)index fromDir:(NSString *)fromDir toDropboxDir:(NSString *)toDir opType:(OperationType)opType resArray:(NSMutableArray *)resArray {
NSString *file = [files objectAtIndex:index];
NSString *srcPath = [fromDir stringByAppendingPathComponent:file];// define your own source file to be uploaded
// NSString *dstPath = [toDir stringByAppendingPathComponent:file];// define your own destination file in Dropbox
_client = [DropboxClientsManager authorizedClient];
if (!_client) {
[DropboxClientsManager authorizeFromController:[UIApplication sharedApplication]
controller:self
openURL:^(NSURL *url) {
[[UIApplication sharedApplication] openURL:url];
}
browserAuth:YES];
} else {
_fileSize = [FCFileManager sizeOfFileAtPath:srcPath];// get file size
_file = [NSFileHandle fileHandleForReadingAtPath:srcPath];
_data = [_file readDataOfLength:DB_BLOCK_SIZE];
_uploadTask = [_client.filesRoutes uploadSessionStartData:_data];
[_uploadTask response:^(DBFILESUploadSessionStartResult * _Nullable result, DBNilObject * _Nullable obj, DBRequestError * _Nullable error) {
DLog(@"result: %@", result);
DLog(@"routeError: %@", obj);
DLog(@"error: %@", error);
if (error == nil) {
_sessionId = result.sessionId;
DBFILESUploadSessionCursor *cursor = [[DBFILESUploadSessionCursor alloc] initWithSessionId:result.sessionId offset:[NSNumber numberWithUnsignedLongLong:_file.offsetInFile]];
[self uploadNext:cursor];
} else {
[_file closeFile];
}
}];
[_uploadTask progress:^(int64_t bytesWritten, int64_t totalBytesWritten, int64_t totalBytesExpectedToWrite) {
NSLog(@"Start: bytesWritten = %lld", bytesWritten);
}];
}
return;
}
- (void)uploadNext:(DBFILESUploadSessionCursor *)cursor {
if ([_fileSize unsignedLongLongValue] - _file.offsetInFile > DB_BLOCK_SIZE) {
_data = [_file readDataOfLength:DB_BLOCK_SIZE];
} else {
unsigned long long rest = [_fileSize unsignedLongLongValue] - _file.offsetInFile;
_data = [_file readDataOfLength:rest];
}
if (_data.length < DB_BLOCK_SIZE) {
DBFILESCommitInfo *info = [[DBFILESCommitInfo alloc] initWithPath:@"/temp/test.mp4"];// define your destination file
_finishTask = [_client.filesRoutes uploadSessionFinishData:cursor commit:info inputData:_data];
[_finishTask response:^(DBFILESFileMetadata * _Nullable meta, DBFILESUploadSessionFinishError * _Nullable finishError, DBRequestError * _Nullable error) {
DLog(@"meta: %@", meta);
DLog(@"finishError: %@", finishError);
DLog(@"error: %@", error);
}];
return;
}
_continueTask = [_client.filesRoutes uploadSessionAppendV2Data:cursor inputData:_data];
[_continueTask response:^(DBNilObject * _Nullable obj, DBFILESUploadSessionLookupError * _Nullable lookupError, DBRequestError * _Nullable error) {
DLog(@"obj: %@", obj);
DLog(@"lookupError: %@", lookupError);
DLog(@"error: %@", error);
if (error == nil) {
DLog(@"_file.offsetInFile: %lld", _file.offsetInFile);
DBFILESUploadSessionCursor *cursor = [[DBFILESUploadSessionCursor alloc] initWithSessionId:_sessionId offset:[NSNumber numberWithUnsignedLongLong:_file.offsetInFile]];
[self uploadNext:cursor];
} else {
[_file closeFile];
}
}];
[_continueTask progress:^(int64_t bytesWritten, int64_t totalBytesWritten, int64_t totalBytesExpectedToWrite) {
NSLog(@"Continue: bytesWritten = %lld", bytesWritten);
}];
}
@end
About Dropbox API Support & Feedback
Find help with the Dropbox API from other developers.
