Cut the Clutter: Test Ignore Files Feature - sign up to become a beta tester here.
Forum Discussion
tfrysinger
6 years agoExplorer | Level 4
Cancelling a file upload or download using Java 2 API
I have implemented a file upload and download capability in my Android app using the example approaches posted on GitHub. However, I need a way to interrupt the process to support the notion of 'cancel' by the user. There doesn't seem to be a way to do this? Once I get this far:
FileMetadata metadata = dbxClient.files().uploadBuilder(uploadPath + "/" + localFile.getName())
.withMode(WriteMode.OVERWRITE)
.withClientModified(new Date(localFile.lastModified()))
.uploadAndFinish(in, progressListener);
This blocks internally to the API until the upload is complete. I realize I can use the 'limit' setting in a loop like this:
while ((size - uploaded) > CHUNKED_UPLOAD_CHUNK_SIZE) { dbxClient.files() .uploadSessionAppendV2(cursor) .uploadAndFinish(in, CHUNKED_UPLOAD_CHUNK_SIZE, progressListener); uploaded += CHUNKED_UPLOAD_CHUNK_SIZE; cursor = new UploadSessionCursor(sessionId, uploaded); }
And then check for an interrupted condition prior to initializing 'cursor' again, is this the only way? It means a delay to the user depending on how big "CHUNKED_UPLOAD_CHUNK_SIZE" is, and I'd rather not have to play games optimizing this value on the relatively low chance that the user cancels. I'd rather be able to interrupt the process whenever it needs to be interrupted.
6 Replies
- Greg-DB6 years ago
Dropbox Community Moderator
When using the Dropbox API v2 Java SDK, you can cancel an in-progress upload by using the DbxUploader.abort method. That's available on its sub-classes for various use cases, such as UploadUploader, UploadSessionStartUploader, UploadSessionAppendV2Uploader, and UploadSessionFinishUploader.
For example, you can get the UploadUploader from upload or UploadBuilder.start (as opposed to directly chaining on uploadAndFinish).
That would look something like this: first, set up and save your uploader:
UploadUploader uploader = dbxClient.files().uploadBuilder(path) .withMode(WriteMode.OVERWRITE) .withClientModified(new Date(localFile.lastModified())) .start();
Then, start the upload (maybe on another thread):
fileMetadata = uploader.uploadAndFinish(in, progressListener);
And if/when you need to cancel that upload:
if (someCondition) { uploader.abort(); }
The DbxDownloader class doesn't offer an abort method, but you can use DbxDownloader.getInputStream to get an InputStream so you can more directly control if/when/how much data to read from it.
Hope this helps!
- tfrysinger6 years agoExplorer | Level 4
Hi - that helps a lot on the upload area.
For the download, I'm not sure I follow how getting a reference to the InputStream helps here. I suppose if I could read from it in "chunks" similar to upload, I could check every "chunk" to see if a cancel had been indicated, but I'm not sure how to do that.
Do you have a small code example to share?
Thanks!
- tfrysinger6 years agoExplorer | Level 4
Is something like this appropriate?
DbxDownloader<FileMetadata> downloader = dbxClient.files().downloadBuilder(dropboxPath + "/" + localFile) .start(); InputStream inputStream = downloader.getInputStream(); int count; long bytesWritten = 0; boolean keepGoin = true; byte data[] = new byte[WRITE_BUFFER]; while ( keepGoin && ((count = inputStream.read(data, 0, WRITE_BUFFER)) != -1)) { outputStream.write(data, 0, count); bytesWritten += count; progressListener.onProgress(bytesWritten); if ( listener != null ) { keepGoin = listener.cancelFileOperation(); } } if ( bytesWritten != size) { // Means we were interrupted throw new UserCancelException(InTouch.getInstance().getString(R.string.interrupted_exception_cancel_xfer)); }
- Greg-DB6 years ago
Dropbox Community Moderator
Apologies I didn't have a code sample for that handy, but yes, what you just shared looks like what I had in mind.
- tfrysinger6 years agoExplorer | Level 4
Greg -
Once I issue .start(), do I need to do anything other than close the streams to correctly end this transaction?
- Greg-DB6 years ago
Dropbox Community Moderator
You should just use DbxDownloader.close when you're finished with the downloader (which will close the InputStream returned by getInputStream for you), in addition to closing any streams you opened yourself.
About Dropbox API Support & Feedback
Find help with the Dropbox API from other developers.6,037 PostsLatest Activity: 3 years ago
The Dropbox Community team is active from Monday to Friday. We try to respond to you as soon as we can, usually within 2 hours.
If you need more help you can view your support options (expected response time for an email or ticket is 24 hours), or contact us on X or Facebook.
For more info on available support options for your Dropbox plan, see this article.
If you found the answer to your question in this Community thread, please 'like' the post to say thanks and to let us know it was useful!